Open
Conversation
Added more test cases
changed way of converting buffer to hex in signAndExecuteMetaTx
Fixed issues with option pricing fomula
…lotxContract into v2-singleCurrencyMarket
…ption pricing function accordingly shifted AllMarket interface to interface file
Skipping settleMarket if feed address is null Handeling create market if feed address is null
…is null removed commented code
…lotxContract into v2-singleCurrencyMarket
Fixed script responsible for signing the meta tx took contracts out of plotxToken.sol Fixed test cases broke due to EIP changes
Implemented EIP 712 in all contracts following MetaTx
Collaborator
|
|
Collaborator
Author
|
Yes, msg.sender is added intentionally wherever the particular function is to be called by any contract or the relayer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refer this sheet, for the list of changes made to the contracts